httpd-dev mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From Jeff Trawick <traw...@attglobal.net>
Subject Re: [PATCH] umask bug in prefork.c
Date Sat, 12 Apr 2003 11:15:05 GMT
Jim Carlson wrote:
> This is in prefork.c, chdir_for_gprof().  It looks like apr_dir_make is 
> passed an octal perms argument instead of the hex format required by 
> APR.  This patch seems to solve the problem for me (now my httpd 
> processes can actually write their gmon.out's.)  Assuming I'm correct -- 
> how is it that noone else has been bitten by this?

nobody has done that profiling :)

regarding your change:

> -       res = apr_dir_make(use_dir, 0755, pconf);
> +       res = apr_dir_make(use_dir, 0x755, pconf);

the right fix is to convert the old 0755 into the APR permission flags 
and not worry about what those permission flags map to numerically

for an example of the permission flags, look at apr_file_open() calls in 
Apache

are there other MPMs besides prefork where the same fix is necessary?

thanks,

Jeff


Mime
View raw message