Return-Path: Delivered-To: apmail-httpd-dev-archive@httpd.apache.org Received: (qmail 41096 invoked by uid 500); 9 Mar 2003 00:40:14 -0000 Mailing-List: contact dev-help@httpd.apache.org; run by ezmlm Precedence: bulk Reply-To: dev@httpd.apache.org list-help: list-unsubscribe: list-post: Delivered-To: mailing list dev@httpd.apache.org Received: (qmail 41077 invoked from network); 9 Mar 2003 00:40:13 -0000 Message-ID: <3E6A8D18.1060004@stason.org> Date: Sun, 09 Mar 2003 11:38:48 +1100 From: Stas Bekman Organization: Hope, Humanized User-Agent: Mozilla/5.0 (X11; U; Linux i686; en-US; rv:1.1) Gecko/20020826 X-Accept-Language: en-us, en MIME-Version: 1.0 To: dev@httpd.apache.org Subject: Re: need help; main filters are bypassed on internal redirects in subrequests References: Content-Type: text/plain; charset=ISO-8859-1; format=flowed Content-Transfer-Encoding: 8bit X-Spam-Rating: daedalus.apache.org 1.6.2 0/1000/N Andr� Malo wrote: > Bah, what a complicated situation ;-) > gives a good > example (reproducable with a standard installation + SSI + DEFLATE > configured). > > The attached patch solves the problem for me. But somehow I have the > feeling, that it's not the end solution (but would be cool, if it is :). > I'm not sure about all of the implications. What happens, for example, if > the redirects adds some filters itself? Or some filter removes itself. Also what happens to the filter context? You probably need to "deep-copy" the chain. > Index: modules/http/http_request.c > =================================================================== > RCS file: /home/cvs/httpd-2.0/modules/http/http_request.c,v > retrieving revision 1.154 > diff -u -r1.154 http_request.c > --- modules/http/http_request.c 24 Feb 2003 00:57:40 -0000 1.154 > +++ modules/http/http_request.c 8 Mar 2003 01:38:48 -0000 > @@ -398,6 +398,9 @@ > new->input_filters = new->proto_input_filters; > > if (new->main) { > + new->output_filters = r->output_filters; > + new->input_filters = r->input_filters; > + > /* Add back the subrequest filter, which we lost when > * we set output_filters to include only the protocol > * output filters from the original request. -- __________________________________________________________________ Stas Bekman JAm_pH ------> Just Another mod_perl Hacker http://stason.org/ mod_perl Guide ---> http://perl.apache.org mailto:stas@stason.org http://use.perl.org http://apacheweek.com http://modperlbook.org http://apache.org http://ticketmaster.com