httpd-dev mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From "William A. Rowe, Jr." <wr...@rowe-clan.net>
Subject Re: [PATCH] mod_auth_ldap does not compile with WROWE_2_0_45_RC1
Date Wed, 26 Mar 2003 20:26:50 GMT
At 01:52 PM 3/26/2003, Jeff Trawick wrote:
>MATHIHALLI,MADHUSUDAN (HP-Cupertino,ex1) wrote:
>>This is probably the cause.
>>[If strnicmp is available on a platform, but strncasecmp is not, then it's
>>#defined in apr_general.h]
>>diff -r1.8.2.4 mod_auth_ldap.c
>>823c823
>><     if (strnicmp(url, "ldaps", 5) == 0)
>>---
>>
>>>   if (strncasecmp(url, "ldaps", 5) == 0)
>
>so commit to HEAD ASAP and perhaps before long you'll have the last +1 for commiting to
stable (right now you have yours and mine)

Make that three +1, mine... this was simply bogus code ;-)  
Btw... -u diffs please :-)

Your point is taken, we should collect three, so perhaps my commit was
premature, so I apologize.  Anyways, with these three +1's, this will make
it into the final .45 tag.  Nice catch Madhu.

Bill



Mime
View raw message