httpd-dev mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From Joe Orton <jor...@redhat.com>
Subject Re: [PATCH] resend: fix fd leaks
Date Thu, 20 Mar 2003 15:03:20 GMT
On Wed, Mar 19, 2003 at 01:15:21PM -0600, William Rowe wrote:
> At 03:25 AM 3/18/2003, Joe Orton wrote:
> >> >Hi, here is a version of the patch in #17206 which removes the current
> >> >the fd leaks.  Most of these were introduced in this commit
> >> >
> >> >http://marc.theaimsgroup.com/?l=apache-cvs&m=99531770520998&w=2
> >> >
> >> >though the pod leak has been around longer. I haven't checked whether
> >> >the mod_file_cache change in that commit should be reverted as well. The
> >> >patch is against 2.0 HEAD.
> >> >
> >> >Submitted by: Christian Kratzer, Bjoern A. Zeeb
> >> 
> >> +1 here.  I have one comment; please *don't* simply delete those lines
> >> from server/log.c, modules/mappers/mod_rewrite.c and, of course,
> >> modules/loggers/mod_log_config.c.  Please comment them out with
> >> /* XXX: this would be required in the Win32 parent */
> >
> >I don't really understand this... the file_inherit interface concerns
> >whether files are inherited by exec()d processes, not any "child
> >processes", on Unix.  Is there some mismatch in the Win32
> >implementation?  Why should httpd need this APR call specifically for
> >Win32?
> 
> As I mentioned before, I'm +1 on this patch.  I'll put back the appropriate
> comments in httpd-2.1-dev since this will be nearly impossible to fix
> for Win32 without breaking many things that we wouldn't consider good
> for the health of 2.0-releases.

Thanks, I still don't really grasp the Win32 side of things, so I'd
rather that you added the appropriate comments.

Let me know if there's anything more I can do.

joe

Mime
View raw message