httpd-dev mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From Geoff Thorpe <ge...@geoffthorpe.net>
Subject Re: [PATCH] openssl versions?
Date Thu, 13 Mar 2003 16:27:58 GMT
Hi there,

Thanks for filling in the SSL-C bits Madhu, looks like a clean fit.

* MATHIHALLI,MADHUSUDAN (HP-Cupertino,ex1) (madhusudan_mathihalli@hp.com) wrote:
> 
> > -----Original Message-----
> > From: William A. Rowe, Jr. [mailto:wrowe@rowe-clan.net]

[snip]

> > Anyways, nice patch - I'd prefer if you would follow the "Fix One Thing"
> > rule of committing this patch; e.g. take it back apart and have each
> > commit labeled as to it's single purpose.  But at least here, I'm +1 for
> this
> > to go into 2.1-dev and I'll help continue to review/improve it in-tree. 
> 
> 
> Oh yes definitely - I'll break it into small patches and commit them
> seperately.
> I had no intention of committing it to the 2.0-dev.

I would, for my part, be quite cautious about putting the new detection
code into any existing stable branch. There's a certain amount of apples
and oranges involved here - the new detection is essentially autoconf
all the way and the existing stuff contains lots of hard-coded paths and
*file* checks (as opposed to $(CPP)/$(CC) tests). The autoconf approach
is clearly preferable, but whether this has the capacity to bite anyone
whose build system or installation target is dependant on the oddities
of the existing behaviour is another question.

Cheers,
Geoff

-- 
Geoff Thorpe
geoff@geoffthorpe.net
http://www.geoffthorpe.net/


Mime
View raw message