Mailing-List: contact dev-help@httpd.apache.org; run by ezmlm
Precedence: bulk
Reply-To: dev@httpd.apache.org
Message-ID: <3E60189F.8020200@attglobal.net>
Date: Fri, 28 Feb 2003 21:19:11 -0500
From: Jeff Trawick <trawick@attglobal.net>
Reply-To: trawick@attglobal.net
User-Agent: Mozilla/5.0 (Windows; U; Windows NT 5.0; en-US;
 rv:1.2b) Gecko/20021016
MIME-Version: 1.0
To: dev@httpd.apache.org
Subject: Re: cvs commit: httpd-2.0/server connection.c
References: <20030225232521.62457.qmail@icarus.apache.org>
 <20030225232521.62457.qmail@icarus.apache.org>
 <5.2.0.9.2.20030226113939.047a3ac0@pop3.rowe-clan.net>
 <3E5E26D8.4040001@attglobal.net> <3E5E9A24.1080703@stason.org>
 <3E5F61E2.90507@attglobal.net> <3E60020B.9010709@stason.org>
 <3E60079D.2050609@attglobal.net> <3E600903.1080407@stason.org>
In-Reply-To: <20030225232521.62457.qmail@icarus.apache.org>
Content-Type: text/plain; charset=us-ascii; format=flowed
Content-Transfer-Encoding: 7bit

Stas Bekman wrote:

 > Jeff Trawick wrote:
 >
 > > Stas Bekman wrote:
 > >
 > >> Should I update Changes for this fix as well?
 > >
 >
 > I was asking whether I should have also logged this last change:
 >
 >    AP_CORE_DECLARE(void) ap_process_connection(conn_rec *c, void *csd)
 >    {
 >   -    apr_status_t rc;
 >   +    int rc;
 >
 > My common sense says no, but one can't be too sure...

oh, right you are...  don't log something like that

if it changes code from prior release and it is user visible, log it;
otherwise, probably not if you ask me unless it is something really big 
like making mod_rewrite easier to read :)