Mailing-List: contact dev-help@httpd.apache.org; run by ezmlm
Precedence: bulk
Reply-To: dev@httpd.apache.org
Message-ID: <3E5BDA5A.90704@wstoddard.com>
Date: Tue, 25 Feb 2003 16:04:26 -0500
From: Bill Stoddard <bill@wstoddard.com>
User-Agent: Mozilla/5.0 (Windows; U; Windows NT 5.0; en-US;
 rv:1.3a) Gecko/20021212
MIME-Version: 1.0
To: dev@httpd.apache.org
Subject: Re: [PATCH] Move http header parsing into the http_input_filter
References: <3E5A5486.2010407@wstoddard.com> <2147483647.1046133723@localhost>
 <3E5BBA24.70604@wstoddard.com> <2147483647.1046174021@[10.0.1.12]>
In-Reply-To: <2147483647.1046174021@[10.0.1.12]>
Content-Type: text/plain; charset=us-ascii; format=flowed
Content-Transfer-Encoding: 7bit

Justin Erenkrantz wrote:
> --On Tuesday, February 25, 2003 1:47 PM -0500 Bill Stoddard 
> <bill@wstoddard.com> wrote:
> 
>> I have to responds to this (even though I am up to my ears in other
>> work)... If bb contains -any- bytes after after the call to
>> ap_get_brigade(), then there is something wrong (that is fixable)
>> in the filter stack. As I envision how this should operate, bb
>> should be empty when we call apr_brigade_destroy. It it is not,
>> then something else is broken.
> 
> 
> Huh?  How would a client read the body?  ap_get_brigade has to return 
> data.  If you say that we now must always throw away the first read, 
> you're scoring high on my hack-o-meter.  =)  We went this approach 
> earlier with AP_MODE_INIT, but, ISTR, we ended up removing it.  -- justin
> 

Ahh, okay my bad. It's a bug. Told you I have not tested this with POST 
requests :-)

Bill