Return-Path: Delivered-To: apmail-httpd-dev-archive@httpd.apache.org Received: (qmail 45254 invoked by uid 500); 25 Feb 2003 19:53:34 -0000 Mailing-List: contact dev-help@httpd.apache.org; run by ezmlm Precedence: bulk Reply-To: dev@httpd.apache.org list-help: list-unsubscribe: list-post: Delivered-To: mailing list dev@httpd.apache.org Received: (qmail 45213 invoked from network); 25 Feb 2003 19:53:33 -0000 Date: Tue, 25 Feb 2003 11:53:41 -0800 From: Justin Erenkrantz To: dev@httpd.apache.org Subject: Re: [PATCH] Move http header parsing into the http_input_filter Message-ID: <2147483647.1046174021@[10.0.1.12]> In-Reply-To: <3E5BBA24.70604@wstoddard.com> References: <3E5A5486.2010407@wstoddard.com> <2147483647.1046133723@localhost> <3E5BBA24.70604@wstoddard.com> X-Mailer: Mulberry/3.0.0 (Mac OS X) MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii; format=flowed Content-Transfer-Encoding: 7bit Content-Disposition: inline X-Spam-Status: No, hits=-2.5 required=5.0 tests=IN_REP_TO,QUOTED_EMAIL_TEXT,REFERENCES,REPLY_WITH_QUOTES version=2.50-cvs X-Spam-Rating: daedalus.apache.org 1.6.2 0/1000/N --On Tuesday, February 25, 2003 1:47 PM -0500 Bill Stoddard wrote: > I have to responds to this (even though I am up to my ears in other > work)... If bb contains -any- bytes after after the call to > ap_get_brigade(), then there is something wrong (that is fixable) > in the filter stack. As I envision how this should operate, bb > should be empty when we call apr_brigade_destroy. It it is not, > then something else is broken. Huh? How would a client read the body? ap_get_brigade has to return data. If you say that we now must always throw away the first read, you're scoring high on my hack-o-meter. =) We went this approach earlier with AP_MODE_INIT, but, ISTR, we ended up removing it. -- justin