httpd-dev mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From Justin Erenkrantz <jus...@erenkrantz.com>
Subject Re: [PATCH] Make "Symbolic link not allowed" log message more verbose
Date Thu, 20 Feb 2003 21:15:55 GMT
--On Monday, February 17, 2003 10:04:58 +0000 Andrew Eland 
<andrew@andreweland.org> wrote:

> @@ -1017,12 +1046,11 @@
>              if (thisinfo.filetype == APR_LNK) {
>                  /* Is this a possibly acceptable symlink?
>                   */
> +                resolve_symlink_result res;
>                  if ((res = resolve_symlink(r->filename, &thisinfo,
>                                             opts.opts, r->pool)) != OK) {
> -                    ap_log_rerror(APLOG_MARK, APLOG_ERR, 0, r,
> -                                  "Symbolic link not allowed: %s",
> -                                  r->filename);
> -                    return r->status = res;
> +                    log_resolve_symlink_result(res, r);
> +                    return r->status = HTTP_FORBIDDEN;
>                  }
>              }

You are shadowing the 'int res' declaration here.  Please select another 
variable name.  -- justin

Mime
View raw message