httpd-dev mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From Mads Toftum <m...@toftum.dk>
Subject Re: PR 17462: let mod_rewrite hard limit its internal redirects
Date Thu, 27 Feb 2003 15:30:57 GMT
On Thu, Feb 27, 2003 at 03:07:31PM +0100, André Malo wrote:
> I'd guess this has bitten a lot of people. There are several cases, in 
> which mod_rewrite runs into a deadloop of internal redirects.
> 
> I think, we can fix it by counting the times the fixup hook effectively 
> works (regardless of equality of the uris) and stop after a configurable 
> limit, e.g.
> 
> RewriteOptions MaxRedirects=x
> 
> where x defaults to 10 or so.
> mod_rewrite could store that value in r->request_config. If it's exceeded, 
> a config error is assumed and an error logged. The response should be 500 
> then.
> 
> WDYT?
> 
Generally I like the idea, but I'm a bit wary about setting a default value
other than unlimited because it could break existing configs. The other 
thing I'm not quite sure about is how you would make this work for rules
in .htaccess? (but I may be missing something) 

vh

Mads Toftum
-- 
`Darn it, who spiked my coffee with water?!' - lwall


Mime
View raw message