httpd-dev mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From Dirk-Willem van Gulik <di...@webweaving.org>
Subject Re: round 2 of mod_authn_mysql
Date Wed, 19 Feb 2003 09:09:29 GMT

Your 0.6 version works splendidly. Does not seem to leak (well; less than
I can detect as I have other stuff leaking) and survives restarts and
other harrasment well.

Last nit:

	#define MYSQL_HARD_MAX_CONNS (255)
to
	#ifndef MYSQL_HARD_MAX_CONNS
	#define MYSQL_HARD_MAX_CONNS (255)
	#endif

would allow for makefile override. You also *may* (not sure) be able to
easily use apr_strerror() to get a human readable error out of the APR;
rather than report a %d. Though that may require a buffer and other
expensive pain which is prohibitive.

Dw


Mime
View raw message