httpd-dev mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From André Malo>
Subject Re: cvs commit: httpd-2.0/modules/filters mod_deflate.c
Date Thu, 02 Jan 2003 04:23:11 GMT
* Justin Erenkrantz wrote:

> We don't use mixed case for any definitions, and we require braces at
> all times, and for macros longer than one line, we wrap it with a do
> {} while (0) clause so that some compilers are a bit happier.

ah ok, thanks.


> All of that said, I'm not really sure this code even merits being a
> macro.  I'd rather see the conditional execution clear at the scope
> where LeaveNote is called rather than hidden in its definition.
> Yeah, it's slightly repetitive, but I'm not really buying what the
> macro is getting us here.  IMHO, there should be an extremely high bar
> to creating a macro.

My thought was mainly to get some (perhaps subtle) semantics and better 
readability. But I've no problem to put this directly into the code; it's 
not so much, that one would loose the overview.

...tomorrow, if the time is ok ;-)

\40\51/\134\137|ndparker <>;;print;

View raw message