httpd-dev mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From André Malo ...@perlig.de>
Subject Re: Review desired - mod_ident
Date Thu, 16 Jan 2003 16:09:59 GMT
* Justin Erenkrantz wrote:

> --On Wednesday, January 15, 2003 2:32 AM +0100 André Malo
> <nd@perlig.de> wrote:
> 
>> I'd like to let someone review before committing, because it's at
>> least a  bunch of core changes.
> 
> Looks good upon cursory review.  I think we could optimize some of
> the socket calls (short read/write cases), but that was there before.
> We could always clean that up later.  (sscanf - ugh!)
> 
> My only real complaint is the tabs/formatting.  =)  There seem to be
> lots of whitespace issues.  (Again, there before, but we ought to
> clean it up when we place it in the new location.)

ah well, c&p from rfc1413.c ;-)
I'll run a tab killer and whitespace cleanup before committing. For better 
reproducing of the changes, I think, the code cleanup is better to apply 
later.
Another question: I guess, the change does require an MMN bump, doesn't it?

nd
-- 
Da fällt mir ein, wieso gibt es eigentlich in Unicode kein
"i" mit einem Herzchen als Tüpfelchen? Das wär sooo süüss!
 
                                 -- Björn Höhrmann in darw

Mime
View raw message