Mailing-List: contact dev-help@httpd.apache.org; run by ezmlm
Precedence: bulk
Reply-To: dev@httpd.apache.org
Date: Tue, 17 Dec 2002 14:09:43 -0500 (EST)
From: Cliff Woolley <jwoolley@virginia.edu>
To: dev@httpd.apache.org
Subject: Re: cvs commit: httpd-2.0/modules/experimental mod_cache.c
In-Reply-To: <20021217190353.GA24855@manyfish.co.uk>
Message-ID: 
 <Pine.LNX.4.44.0212171409060.519-100000@bistromath.cs.virginia.edu>
MIME-Version: 1.0
Content-Type: TEXT/PLAIN; charset=US-ASCII

On Tue, 17 Dec 2002, Joe Orton wrote:

> On Tue, Dec 17, 2002 at 05:10:05PM -0000, Bill Stoddard wrote:
> >            else if (exps != NULL && exp == APR_DATE_BAD) {
> >                /* if a broken Expires header is present, don't cache it */
> >   -            reason = apr_pstrcat(p, "Broken expires header %s", exp);
> >   +            reason = apr_psprintf(p, "Broken expires header %s", exp);
>
> Still not right - 'exp' is an apr_time_t, you mean 'exps' I guess?
>
> mod_cache.c: In function `cache_in_filter':
> mod_cache.c:543: warning: format argument is not a pointer (arg 3)


Oooh, yowtch... good call.  I wasn't even looking at that part.

--Cliff