Return-Path: Delivered-To: apmail-httpd-dev-archive@httpd.apache.org Received: (qmail 43210 invoked by uid 500); 9 Dec 2002 19:02:25 -0000 Mailing-List: contact dev-help@httpd.apache.org; run by ezmlm Precedence: bulk Reply-To: dev@httpd.apache.org list-help: list-unsubscribe: list-post: Delivered-To: mailing list dev@httpd.apache.org Received: (qmail 43197 invoked from network); 9 Dec 2002 19:02:25 -0000 From: "Bill Stoddard" To: Subject: [PATCH] Suppress proxy: error linking cache file... Date: Mon, 9 Dec 2002 14:04:48 -0500 Message-ID: MIME-Version: 1.0 Content-Type: text/plain; charset="iso-8859-1" Content-Transfer-Encoding: 7bit X-Priority: 3 (Normal) X-MSMail-Priority: Normal X-Mailer: Microsoft Outlook IMO, Build 9.0.2416 (9.0.2911.0) Importance: Normal X-MimeOLE: Produced By Microsoft MimeOLE V6.00.2600.0000 X-Spam-Rating: daedalus.apache.org 1.6.2 0/1000/N There have been a couple of PRs opened against this. I believe the condition arises when the server is configured as a proxy gateway (aka reverse proxy) and multiple processes are serving the same backend file at the same time. Only one of the processes will actually succeed at saving the file, the others will fail with the message "[error] (17)File exists: proxy: error linking cache file ...". Changing the message level from APLOG_ERR to APLOG_INFO will keep this message out of the logs w/o major overhaul of this code. Any objections to committing this to 1.3? $ cvs diff -u proxy_cache.c Index: proxy_cache.c =================================================================== RCS file: /home/cvs/apache-1.3/src/modules/proxy/proxy_cache.c,v retrieving revision 1.89 diff -u -r1.89 proxy_cache.c --- proxy_cache.c 5 Sep 2002 19:53:35 -0000 1.89 +++ proxy_cache.c 9 Dec 2002 18:56:17 -0000 @@ -1799,7 +1799,7 @@ #else if (link(c->tempfile, c->filename) == -1) - ap_log_error(APLOG_MARK, APLOG_ERR, s, + ap_log_error(APLOG_MARK, APLOG_INFO, s, "proxy: error linking cache file %s to %s", c->tempfile, c->filename); if (unlink(c->tempfile) == -1) $