Return-Path: Delivered-To: apmail-httpd-dev-archive@httpd.apache.org Received: (qmail 55645 invoked by uid 500); 17 Dec 2002 19:03:31 -0000 Mailing-List: contact dev-help@httpd.apache.org; run by ezmlm Precedence: bulk Reply-To: dev@httpd.apache.org list-help: list-unsubscribe: list-post: Delivered-To: mailing list dev@httpd.apache.org Received: (qmail 55623 invoked from network); 17 Dec 2002 19:03:30 -0000 Date: Tue, 17 Dec 2002 19:03:53 +0000 From: Joe Orton To: dev@httpd.apache.org Subject: Re: cvs commit: httpd-2.0/modules/experimental mod_cache.c Message-ID: <20021217190353.GA24855@manyfish.co.uk> Mail-Followup-To: dev@httpd.apache.org References: <20021217171005.16302.qmail@icarus.apache.org> Mime-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: <20021217171005.16302.qmail@icarus.apache.org> User-Agent: Mutt/1.4i X-Spam-Rating: daedalus.apache.org 1.6.2 0/1000/N On Tue, Dec 17, 2002 at 05:10:05PM -0000, Bill Stoddard wrote: > Fix PR 15113, a core dump in cache_in_filter when > a redirect occurs. The code was passing a format string and > integer to apr_pstrcat. Changed to apr_psprintf. [Paul J. Reder] > > PR: 15113 ... > else if (exps != NULL && exp == APR_DATE_BAD) { > /* if a broken Expires header is present, don't cache it */ > - reason = apr_pstrcat(p, "Broken expires header %s", exp); > + reason = apr_psprintf(p, "Broken expires header %s", exp); Still not right - 'exp' is an apr_time_t, you mean 'exps' I guess? mod_cache.c: In function `cache_in_filter': mod_cache.c:543: warning: format argument is not a pointer (arg 3)