Return-Path: 
 <dev-return-35247-apmail-httpd-dev-archive=httpd.apache.org@httpd.apache.org>
Delivered-To: apmail-httpd-dev-archive@httpd.apache.org
Received: (qmail 29052 invoked by uid 500); 17 Dec 2002 22:17:20 -0000
Mailing-List: contact dev-help@httpd.apache.org; run by ezmlm
Precedence: bulk
Reply-To: dev@httpd.apache.org
list-help: <mailto:dev-help@httpd.apache.org>
list-unsubscribe: <mailto:dev-unsubscribe@httpd.apache.org>
list-post: <mailto:dev@httpd.apache.org>
Delivered-To: mailing list dev@httpd.apache.org
Received: (qmail 29039 invoked from network); 17 Dec 2002 22:17:19 -0000
Subject: Re: [PATCH] move CachemaxStreamingBuffer from mod_cache to
	mod_mem_cache
From: Brian Pane <brian.pane@cnet.com>
To: dev@httpd.apache.org
In-Reply-To: <JHEPKCEMGPKFFDHHDDKDAEGLGGAA.bill@wstoddard.com>
References: <JHEPKCEMGPKFFDHHDDKDAEGLGGAA.bill@wstoddard.com>
Content-Type: text/plain
Organization: 
Message-Id: <1040163163.1226.28.camel@desktop>
Mime-Version: 1.0
X-Mailer: Ximian Evolution 1.2.0 
Date: 17 Dec 2002 14:12:43 -0800
Content-Transfer-Encoding: 7bit
X-Spam-Rating: daedalus.apache.org 1.6.2 0/1000/N

On Tue, 2002-12-17 at 12:35, Bill Stoddard wrote:
> This patch does the following:
> 
> 1. Renames CacheMaxStreamingBuffer to MCacheMaxStreamingBuffer
> 
> 2. Moves implementation of MCacheMaxStreamingBuffer from mod_cache to
> mod_mem_cache
> 
> 3. Implements default value of MCacheMaxStreamingBuffer (100000 bytes) which is
> adjusted downward if the default exceeds the setting of MCacheMaxCacheObjectSize
> (I was not too keen on setting default MCacheMaxStreamingBuffer to be equal to
> MCacheMaxCacheObjectSize for reasons pointed out by Brian Pane).
> 
> The patch is filtered to ignore changes in spacing (cvs diff -u -b). I still
> have a bit of cleanup to do in the cache size check area (I am not convinced the
> original code worked all that well) and I'm planning on fixing that tomorrow.

I just tested this patch, and it doesn't seem to cache
responses that span multiple brigades.

Configuration:

<IfModule mod_mem_cache.c>
CacheEnable mem /
MCacheSize 4096
MCacheMaxObjectCount 100
MCacheMinObjectSize 1
MCacheMaxObjectSize 16384
MCacheMaxStreamingBuffer 10300
</IfModule>

<IfModule mod_bucketeer.c>
AddOutputFilter BUCKETEER .html
</IfModule>

Test case:
  1. Create a 1024-byte file
  2. Put a Ctrl-F in the middle of it (so that mod_bucketeer
     will split the file and flush the first brigade)
  3. Request the file

Result:
[Tue Dec 17 14:07:57 2002] [debug] mod_mem_cache.c(475): cache_mem: URL
/1k.html? failed the size check, or is incomplete

Without any mod_bucketeer intervention, mod_mem_cache caches
the file successfully.

Brian