httpd-dev mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From André Malo ...@perlig.de>
Subject Re: bug 12395
Date Sat, 28 Dec 2002 17:14:27 GMT
* Dr. Georg Czedik-Eysenberg wrote:

> But on the other hand it is now about 4 months,
> since I entered the "bug report 12395" into Bugzilla
> (http://nagoya.apache.org/bugzilla/show_bug.cgi?id=12395)
> and it is still in the state "NEW".

<snip>

this bug should be easy to fix:

mod_rewrite.c, HEAD, line 1412:

    /*
     *  only do something under runtime if the engine is really enabled,
     *  for this directory, else return immediately!
     */
    if (!(ap_allow_options(r) & (OPT_SYM_LINKS | OPT_SYM_OWNER))) {
        /* FollowSymLinks is mandatory! */
        ap_log_rerror(APLOG_MARK, APLOG_ERR, 0, r,
                     "Options FollowSymLinks or SymLinksIfOwnerMatch is off 
"
                     "which implies that RewriteRule directive is 
forbidden: "
                     "%s", r->filename);
        return HTTP_FORBIDDEN;
    }
    else {
        /* FollowSymLinks is given, but the user can
         * still turn off the rewriting engine
         */
        if (dconf->state == ENGINE_DISABLED) {
            return DECLINED;
        }
    }

the two conditional branches simply have to be swapped. Or better we could 
remove the else-branch and put the disabled-check before the 'if'. Or...?

nd
-- 
my @japh = (sub{q~Just~},sub{q~Another~},sub{q~Perl~},sub{q~Hacker~});
my $japh = q[sub japh { }]; print join       #########################
 [ $japh =~ /{(.)}/] -> [0] => map $_ -> ()  #            André Malo #
=> @japh;                                    # http://www.perlig.de/ #

Mime
View raw message