httpd-dev mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From "Bill Stoddard" <b...@wstoddard.com>
Subject RE: [PATCH] Fix proxy's handling of input bodies
Date Tue, 03 Dec 2002 13:04:33 GMT
> Currently, mod_proxy falls down if a filter is in the input chain
> that changes the content of the original request.  It will send the
> original Content-Length not the size of the data it actually sends.
> If the request was originally chunked, but the data it actually sends
> isn't chunked (it sends no C-L header in this case).  Oops.
>
> This patch changes it so that mod_proxy delays setting the
> Content-Length header until we have read the entire body from the
> filters and can recompute the C-L header.  This is kind of icky, but
> there is no way around that if we're sending the C-L header.
>
> What we can do is either do non-keepalive connections

This sounds a bit more reasonable to me. That is, send chunked if the client
will accept chunked, else send a connection: close header (which will tell the
client we are done sending).  As a compromise, we could start off buffering and
if we hit some magic threshold and we still do not know the c-l, add a
connection: close header and start sending.

Bill


Mime
View raw message