httpd-dev mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From "Bill Stoddard" <b...@wstoddard.com>
Subject RE: [PATCH] move CachemaxStreamingBuffer from mod_cache tomod_mem_cache
Date Tue, 17 Dec 2002 21:49:45 GMT
I see what's wrong. Will post an updated patch ASAP.

Bill

>
> On Tue, 2002-12-17 at 12:35, Bill Stoddard wrote:
> > This patch does the following:
> >
> > 1. Renames CacheMaxStreamingBuffer to MCacheMaxStreamingBuffer
> >
> > 2. Moves implementation of MCacheMaxStreamingBuffer from mod_cache to
> > mod_mem_cache
> >
> > 3. Implements default value of MCacheMaxStreamingBuffer (100000
> bytes) which is
> > adjusted downward if the default exceeds the setting of
> MCacheMaxCacheObjectSize
> > (I was not too keen on setting default MCacheMaxStreamingBuffer to
> be equal to
> > MCacheMaxCacheObjectSize for reasons pointed out by Brian Pane).
> >
> > The patch is filtered to ignore changes in spacing (cvs diff -u -b). I still
> > have a bit of cleanup to do in the cache size check area (I am not
> convinced the
> > original code worked all that well) and I'm planning on fixing that
> tomorrow.
>
> I just tested this patch, and it doesn't seem to cache
> responses that span multiple brigades.
>
> Configuration:
>
> <IfModule mod_mem_cache.c>
> CacheEnable mem /
> MCacheSize 4096
> MCacheMaxObjectCount 100
> MCacheMinObjectSize 1
> MCacheMaxObjectSize 16384
> MCacheMaxStreamingBuffer 10300
> </IfModule>
>
> <IfModule mod_bucketeer.c>
> AddOutputFilter BUCKETEER .html
> </IfModule>
>
> Test case:
>   1. Create a 1024-byte file
>   2. Put a Ctrl-F in the middle of it (so that mod_bucketeer
>      will split the file and flush the first brigade)
>   3. Request the file
>
> Result:
> [Tue Dec 17 14:07:57 2002] [debug] mod_mem_cache.c(475): cache_mem: URL
> /1k.html? failed the size check, or is incomplete
>
> Without any mod_bucketeer intervention, mod_mem_cache caches
> the file successfully.
>
> Brian
>


Mime
View raw message