httpd-dev mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From Greg Marr <gr...@alum.wpi.edu>
Subject Re: cvs commit: httpd-2.0/modules/experimental mod_cache.c
Date Tue, 17 Dec 2002 19:26:28 GMT
At 02:23 PM 12/17/2002, Paul J. Reder wrote:
>Yup, the coredump happened in the first call with the %d. I just 
>patched this second call without looking at the exp parm, then 
>failed to notice the warning... *sigh* must be near Christmas 
>vacation when it takes three passes to get something like this 
>right... ;)

Any reason not to just use apr_pstrcat(p, "Broken expires header ", 
exps) and save the overhead of the psprintf?

>Cliff Woolley wrote:
>
>>On Tue, 17 Dec 2002, Joe Orton wrote:
>>
>>>On Tue, Dec 17, 2002 at 05:10:05PM -0000, Bill Stoddard wrote:
>>>
>>>>           else if (exps != NULL && exp == APR_DATE_BAD) {
>>>>               /* if a broken Expires header is present, don't 
>>>> cache it */
>>>>  -            reason = apr_pstrcat(p, "Broken expires header 
>>>> %s", exp);
>>>>  +            reason = apr_psprintf(p, "Broken expires header 
>>>> %s", exp);
>>>Still not right - 'exp' is an apr_time_t, you mean 'exps' I guess?
>>>
>>>mod_cache.c: In function `cache_in_filter':
>>>mod_cache.c:543: warning: format argument is not a pointer (arg 3)
>>
>>Oooh, yowtch... good call.  I wasn't even looking at that part.

-- 
Greg Marr
gregm@alum.wpi.edu


Mime
View raw message