httpd-dev mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From "William A. Rowe, Jr." <wr...@apache.org>
Subject [PATCH] Native Win32 mod_auth_ldap + util_ldap
Date Sun, 01 Dec 2002 23:59:51 GMT
Attached is the patch for Win32 apr-util support with their build in library.

It is included by default with Windows 2000 and XP; NT 4.0 users may
download it for Windows NT from the address; 

http://www.microsoft.com/ntworkstation/downloads/Other/adclient.asp

It appears Windows 9x (ME) users have a bit more hassle, but it is available;

http://support.microsoft.com/default.aspx?scid=kb;en-us;288358

Attached also is the patch for httpd util_ldap and mod_auth_ldap.  Don't
mind the const'ness warnings just now - since win32 does it's 'own thing'
regarding what aught to accept const.  [Big surprise.]

We also do the 'wrong thing' with respect to apr_ldap_url_parse() const'ness
at the moment.  Needs some thinking through all the way around.

And of course, a bit of this patch wouldn't be needed if we 'just' hack in
the replacement ldap_url_parse() fn.  However, I'm very concerned about
our proliferating namespace conflicts, so I chose another name while I was
hacking this together.

Anyway, patch attached, NT/2k/XP users please experiment and provide
feedback... thanks!

Bill

>From: "William A. Rowe, Jr." <wrowe@covalent.net>
>To: "Apache Portable Runtime Developers" <dev@apr.apache.org>
>Subject: [PATCH] apr-util/ldap cleanups and Native Win32
>Date: Sun, 1 Dec 2002 14:04:58 -0800
>
>First off, I'm not certain how APU_HAS_LDAP defined/undefined semantics ever
>made it into our library, but it is most wrong.  We use APR_ as our namespace except
>internally to apr-util or apr-iconv, and we always use APR_HAS_FOO 1 or 0 as our
>markers.  This patch deprecates the APU_HAS_LDAP[_FOO] defined/undefined
>semantics, and replaces all that conf gook with legitimate 0|1 values for APR_HAS
>flavors of the same.  We should plan to ditch the APU_HAS_foo when we roll out
>with APR 1.0.
>
>So I attacked the ldap using native win32 libraries.  Good news; it almost worked.
>Bad news; we were missing ldap_url_* api functions.
>
>Only one is used in Apache (the most critical one), ldap_url_parse.  Based on OpenLDAP
>this patch offers replacement support for that function alone.  Until someone hollers
for
>support of ldap_url_search* fn's, I didn't see a reason to bloat.
>
>Of course, this introduces a really interesting question; with or without compiled-in
ldap
>support, do we want to grok LDAP urls?  I've always been partial to the idea that
>apr-util exists to extend apr only in RFC-directed quick-fixes, and this is one (2255).
>
>Anywho; for your consideration.  If any Win32/ldap hackers want to look at this, and
>if a NetWare/Unix guru wants to make sure my APU->APR changes made sense,
>please do!
>
>Bill
>

Mime
View raw message