httpd-dev mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From Joe Orton <...@manyfish.co.uk>
Subject Re: cvs commit: httpd-2.0/modules/experimental mod_cache.c
Date Tue, 17 Dec 2002 19:03:53 GMT
On Tue, Dec 17, 2002 at 05:10:05PM -0000, Bill Stoddard wrote:
>   Fix PR 15113, a core dump in cache_in_filter when
>   a redirect occurs. The code was passing a format string and
>   integer to apr_pstrcat. Changed to apr_psprintf. [Paul J. Reder]
>   
>   PR: 15113
...
>            else if (exps != NULL && exp == APR_DATE_BAD) {
>                /* if a broken Expires header is present, don't cache it */
>   -            reason = apr_pstrcat(p, "Broken expires header %s", exp);
>   +            reason = apr_psprintf(p, "Broken expires header %s", exp);

Still not right - 'exp' is an apr_time_t, you mean 'exps' I guess?

mod_cache.c: In function `cache_in_filter':
mod_cache.c:543: warning: format argument is not a pointer (arg 3)


Mime
View raw message