httpd-dev mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From Martin Kraemer <mar...@apache.org>
Subject Re: [PATCH] Have logfiles closed on exec
Date Wed, 11 Dec 2002 21:30:06 GMT
> Here it is:
> 
> Index: src/CHANGES
>  
> +  *) Certain 3rd party modules would bypass [...]

Perhaps you could improve my blurb. It was not written very intelligently....

For the rest:
* the patch as mailed did not apply cleanly here (some tab expansion
  glitches, but only whitespace diffs, but if _you_ commit that's
  no problem)
* after fixing the whitespace stuff, it compiles cleanly, and:
* it *works*, fixes the fd leakage, and is a nicer approach than spreading
  note_cleanup_for_*_ex() all over the place.

>From my side: +1 for a commit!

Thanks!

   Martin

Mime
View raw message