httpd-dev mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From Martin Kraemer <mar...@apache.org>
Subject Re: [PATCH] Have logfiles closed on exec
Date Wed, 11 Dec 2002 17:03:00 GMT
On Wed, Dec 11, 2002 at 11:49:43AM -0500, Jim Jagielski wrote:
> 
> Should the default behavior of ap_popenf be to perform the
> magic cleanup then? We already do so with ap_open_piped_log().

As I said: inside Apache, there's no reason not to change it.
But I don't know how many 3rd party modules out there use
ap_popenf() for other stuff, and perhaps rely on the open fd's staying
open across an exec.  (That's probably different with
ap_open_piped_log() because a piped log is seldom used in an
exec()ed child.)

So, it's safer to stick with the ap_popenf_ex() duplication.

My $.02 --

  Martin
-- 
<Martin.Kraemer@Fujitsu-Siemens.com>         |     Fujitsu Siemens
Fon: +49-89-636-46021, FAX: +49-89-636-47655 | 81730  Munich,  Germany

Mime
View raw message