httpd-dev mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From Brian Pane <brian.p...@cnet.com>
Subject Re: Request for comments: moving the request pool cleanup
Date Thu, 19 Dec 2002 17:45:32 GMT
On Thu, 2002-12-19 at 09:37, Justin Erenkrantz wrote:
> --On Thursday, December 19, 2002 9:28 AM -0800 Brian Pane 
> <brian.pane@cnet.com> wrote:
> 
> > If the connection is aborted after the metadata bucket is
> > pushed into the output filter chain, it would be the core
> > output filter's job to consume and destroy all remaining
> > buckets until it had processed the request-cleanup metadata
> > bucket.
> 
> Ick, ick, ick.  We're trying to move towards core_output_filter *not* 
> to have to process everything if the connection is aborted or an 
> error is detected.  Right now, we do do that, but that is wrong for a 
> whole host of reasons we're slowly figuring out (see semi-recent 
> thread between Jeff and myself and some others about this).

No, we definitely need to do that cleanup in core_output_filter,
because that's the only code that's guaranteed to still be runnable
by the time we detect the aborted connection.  The handler may have
finished running long before the connection is aborted, and in an
async MPM the thread that ran all the other request hooks is likely
to have moved on to a new request.

Brian



Mime
View raw message