Return-Path: Delivered-To: apmail-httpd-dev-archive@httpd.apache.org Received: (qmail 33800 invoked by uid 500); 25 Nov 2002 16:35:40 -0000 Mailing-List: contact dev-help@httpd.apache.org; run by ezmlm Precedence: bulk Reply-To: dev@httpd.apache.org list-help: list-unsubscribe: list-post: Delivered-To: mailing list dev@httpd.apache.org Received: (qmail 33736 invoked from network); 25 Nov 2002 16:35:39 -0000 Message-ID: <3DE24FED.30501@ifrance.com> Date: Mon, 25 Nov 2002 17:29:33 +0100 From: Estrade Matthieu User-Agent: Mozilla/5.0 (X11; U; Linux i686; en-US; rv:1.0.1) Gecko/20020823 Netscape/7.0 X-Accept-Language: fr-fr, en-us, en MIME-Version: 1.0 To: dev@httpd.apache.org Subject: r->server->port problem Content-Type: multipart/mixed; boundary="------------080003050205020209040301" X-Spam-Rating: daedalus.apache.org 1.6.2 0/1000/N This is a multi-part message in MIME format. --------------080003050205020209040301 Content-Type: text/plain; charset=us-ascii; format=flowed Content-Transfer-Encoding: 7bit Hi, I posted a mail about a problem with r->server->port few days ago, I did a patch to correct this bug, but i am not sure it's a bug... the problem was when UseCannonicalName is Off, If i have a request on port 8095 like: GET / HTTP/1.1 Host: mydomain.com \n\n\r my module is using the r->server->port the r->server->port will be ap_default_port because of in server/core.c: (When UseCanonicalName Off) port = r->parsed_uri.port ? r->parsed_uri.port : r->server->port ? r->server->port : ap_default_port(r); so, i did: port = r->parsed_uri.port ? r->parsed_uri.port : r->server->port ? r->server->port : r->connection->local_addr->port ? r->connection->local_addr->port : ap_default_port(r); I dunno if i am true or false. it's now working in my module, it's finding r->server->port = 8095 instead of 80 regards, Estrade Matthieu --------------080003050205020209040301 Content-Type: text/plain; name="patch.serverport" Content-Transfer-Encoding: 7bit Content-Disposition: inline; filename="patch.serverport" ? patch.serverport Index: core.c =================================================================== RCS file: /home/cvspublic/httpd-2.0/server/core.c,v retrieving revision 1.225 diff -u -r1.225 core.c --- core.c 16 Nov 2002 02:27:33 -0000 1.225 +++ core.c 25 Nov 2002 16:25:09 -0000 @@ -905,6 +905,7 @@ */ port = r->parsed_uri.port ? r->parsed_uri.port : r->server->port ? r->server->port : + r->connection->local_addr->port ? r->connection->local_addr->port : ap_default_port(r); } else { /* d->use_canonical_name == USE_CANONICAL_NAME_ON */ --------------080003050205020209040301-- __________________________________________________ Modem offert : 150,92 euros rembours�s sur le Pack eXtense de Wanadoo ! Haut d�bit � partir de 30 euros/mois : http://www.ifrance.com/_reloc/w