httpd-dev mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From Jeff Trawick <traw...@attglobal.net>
Subject Re: cvs commit: httpd-2.0/server request.c
Date Fri, 01 Nov 2002 11:51:39 GMT
Greg Stein <gstein@lyra.org> writes:

> On Fri, Nov 01, 2002 at 03:27:20AM -0000, wrowe@apache.org wrote:
> >...
> >   +++ request.c	1 Nov 2002 03:27:20 -0000	1.118
> >   @@ -924,6 +924,8 @@
> >                /* That temporary trailing slash was useful, now drop it.
> >                 */
> >                if (temp_slash) {
> >   +                temp_slash = 0;
> >   +                AP_ASSERT(r->filename[filename_len-1] == '/');
> 
> Don't you want
> 
>     *temp_slash = '\0';
> 
> ??

As it is, temp_slash is a boolean, not the address of the last char.

But yes it would be better to let temp_slash be NULL or the address of
the last char.

-- 
Jeff Trawick | trawick@attglobal.net
Born in Roswell... married an alien...

Mime
View raw message