httpd-dev mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From Jeff Trawick <traw...@attglobal.net>
Subject Re: [PATCH] mod_deflate extensions
Date Thu, 21 Nov 2002 14:09:04 GMT
Henri Gomez <hgomez@apache.org> writes:

> Jeff Trawick wrote:
> > Henri Gomez <hgomez@apache.org> writes:
> >
> >>And in fine what about mod_deflate to be added by default in
> >>Apache 2.0.44 ?
> >>
> >>And if so should we use the mod_gzip compression functions instead of
> >>depending on zlib ?
> > I would be shocked if any significant subset of the people who have
> > to
> > support this code would be interested in switching the compression
> > engine anyway.  (And changing deflate to use a different compression
> > engine works against the goal of 2.0.44 being a stable release.)
> 
> So what about for 2.0.45 dev ?

My prediction about interest in such a switch was independent of
timeframe.  I doubt that such a switch will ever happen.

> What do you means ?
> 
> - Put zlib full source tree in Apache 2.0 tree and make
>    a static build ?

not all of zlib is necessary...  and if we build zlib as a
library (instead of pulling specific objects into mod_deflate.so) we
have portability problems to deal with...

> - Put part of zlib code in Apache 2.0 source ?

that is what I suspect to be the safest, easiest-to-understand way...
the build would work like on Windows, where the project file for
mod_deflate pulls in the right parts when building mod_deflate.so

another nice feature of this is that if we know we are using our build
of the zlib source then we can turn on the zlib compile option to
namespace-protect the zlib routines and then change mod_deflate to
assume that (but perhaps the compile switch will make mod_deflate use
the namespace-protected versions automatically anyway)...  OtherBill
mentioned this namespace protection before but I haven't had a chance
to play with it

I already saw a user having problems because a shared library used by
a 3rd party module also had a routine called crc32().

> - or make configure detect zlib shared lib and make mod_deflate
>    available by default ?

if this can be made foolproof then this is perhaps a good option
too...  but I'm not sure that is portable on whether the DSO needs to
be linked with zlib or whether httpd needs to be linked with zlib...
and if httpd needs to be linked with zlib then the export file
generation needs to do the right thing...  IIRC, one solution that
would work fine on Linux and Solaris and FreeBSD wouldn't work on
HP-UX (I might have the platforms listed in the wrong place; maybe AIX
was one of the platforms)...

--/--

The reason I'm being a real stick-in-the-mud about this is because
Apache users already seem to have enough trouble getting Apache to
build out of the box, usually because of some screwy setup or other
unexpected conditions that nobody can ever reproduce, and it is very
difficult for me to accept that some quick change to turn on
mod_deflate is going to do anything other than increase these
problems, particularly since I committed various "user errors" myself
getting consistent builds of mod_deflate and zlib.  (Heck, I even
broke the cvs executable on one machine before I found out what was
going on :) )

-- 
Jeff Trawick | trawick@attglobal.net
Born in Roswell... married an alien...

Mime
View raw message