Return-Path: 
 <dev-return-33854-apmail-httpd-dev-archive=httpd.apache.org@httpd.apache.org>
Delivered-To: apmail-httpd-dev-archive@httpd.apache.org
Received: (qmail 54793 invoked by uid 500); 9 Oct 2002 11:11:30 -0000
Mailing-List: contact dev-help@httpd.apache.org; run by ezmlm
Precedence: bulk
Reply-To: dev@httpd.apache.org
list-help: <mailto:dev-help@httpd.apache.org>
list-unsubscribe: <mailto:dev-unsubscribe@httpd.apache.org>
list-post: <mailto:dev@httpd.apache.org>
Delivered-To: mailing list dev@httpd.apache.org
Received: (qmail 54780 invoked from network); 9 Oct 2002 11:11:30 -0000
X-Authentication-Warning: radish.cambridge.redhat.com: jorton set sender to
 jorton@redhat.com using -f
Date: Wed, 9 Oct 2002 12:11:57 +0100
From: Joe Orton <jorton@redhat.com>
To: Joshua Slive <joshua@slive.ca>
Cc: dev@httpd.apache.org
Subject: Re: cvs commit: httpd-2.0/server core.c util_script.c
Message-ID: <20021009111157.GB30099@redhat.com>
Mail-Followup-To: Joshua Slive <joshua@slive.ca>, dev@httpd.apache.org
References: <Pine.NEB.4.44.0210021520020.313-100000@rhombus.znep.com>
 <Pine.GSO.4.31.0210021552420.2906-100000@garibaldi.commerce.ubc.ca>
Mime-Version: 1.0
Content-Type: text/plain; charset=us-ascii
Content-Disposition: inline
In-Reply-To: 
 <Pine.GSO.4.31.0210021552420.2906-100000@garibaldi.commerce.ubc.ca>
User-Agent: Mutt/1.4i
X-Spam-Rating: daedalus.apache.org 1.6.2 0/1000/N

On Wed, Oct 02, 2002 at 03:54:18PM -0700, Joshua Slive wrote:
> 
> On Wed, 2 Oct 2002, Marc Slemko wrote:
> > Lets not encode env variables, as we discussed earlier.
> >
> > Escaping them is bogus and doesn't solve anything since there are all
> > sorts of variables that aren't and shouldn't be encoded.
> 
> +1 to what Marc says.  The encoding serves no purpose.  Preventing the
> sample cgi scripts from being included in a "make install" would be a
> great idea.

If this change does get reverted so that SERVER_NAME is not encoded
internally again, the error includes need updating so that is is encoded
there instead:

--- error/include/bottom.html~	2002-07-11 20:07:03.000000000 +0100
+++ error/include/bottom.html	2002-10-09 12:04:59.000000000 +0100
@@ -6,7 +6,7 @@
 <dl>
 <dd>
 <address>
-  <a href="/"><!--#echo encoding="none" var="SERVER_NAME" --></a>
+  <a href="/"><!--#echo encoding="url" var="SERVER_NAME" --></a>
   <br />
   <!--#config timefmt="%c" -->
   <small><!--#echo encoding="none" var="DATE_LOCAL" --></small>