httpd-dev mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From "MATHIHALLI,MADHUSUDAN (HP-Cupertino,ex1)" <madhusudan_mathiha...@hp.com>
Subject RE: [PATCH] Take 2, ssl_engine_io.c BIO and brigades refactored
Date Fri, 01 Nov 2002 02:44:09 GMT
I couldn't look much into it (because of some other thing that came up), but
the perl-framework gives a failure at :

ssl/http............response had protocol HTTP/0.9 (headers not sent?) at
/tmp/madhum.perl_framework/httpd-test/perl-framework/Apache-Test/lib/Apache/
TestRequest.pm line 405.
dubious
        Test returned status 9 (wstat 2304, 0x900)
DIED. FAILED tests 1-2
        Failed 2/2 tests, 0.00% okay

-Madhu

> -----Original Message-----
> From: William A. Rowe, Jr. [mailto:wrowe@rowe-clan.net]
> Sent: Thursday, October 31, 2002 4:43 PM
> To: dev@httpd.apache.org
> Subject: [PATCH] Take 2, ssl_engine_io.c BIO and brigades refactored
> 
> 
> Folks, once again, please take a look at the attached code.  This time
> around, it actually works ;-)
> 
> This is correct only for the input BIO layer.  The output BIO 
> layer still
> needs alot of work.
> 
> Although I merged SSL_read from two into a single function (against 
> other's preferences), it's necessary because the error cases were
> impossible to grok.  I did split out the bucket_read into a 
> brigade_consume
> function so that half, at least, is much easier to follow.
> 
> brigade_consume is much like brigade_flatten.  However, they aren't
> identical, because you can't do non-blocking reads with 
> brigade_flatten.
> 
> The changes to the SSL input effectively force some data to 
> be returned
> if the filter read was blocking.  However, we will not 
> attempt to pull more
> information off the wire than is available.
> 
> The biggest issue throughout the old code is exception handling.  Of
> course the existing code 'worked' in a way, as long as the flow wasn't
> interrupted and no other errors occured.
> 
> I've tested some POST requests, but if someone can put this on
> the httpd-test/perl-framework and exercise it, I'd really 
> appreciate it.
> 
> Now I'll get to work on the write side of the equation.
> 
> Bill
> 

Mime
View raw message