httpd-dev mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From "William A. Rowe, Jr." <wr...@apache.org>
Subject Re: [PATCH]: Counting of I/O, complete thingy
Date Mon, 14 Oct 2002 14:41:24 GMT
At 11:25 PM 10/13/2002, Bojan Smojver wrote:
>I'm not sure if I missed a spot somewhere in core_output_filter, hopefully not.
>
>After playing a bit with core_input_filter and not getting what I wanted, I kept
>the original input filter in mod_logio (which was working fine to the best of my
>knowledge). However, with the introduction of two new fields in conn_rec, things
>should be even quicker than before. In order to make things symmetrical, the
>actual filter could go into core.c. Otherwise, if mod_logio isn't compiled in,
>the input numbers will always be zero, so other modules won't be able to use
>them (which might be a good thing, not sure here).

Bojan,

  I'm not sure, did you note that the core_output_filter will still be running after
the request rec is gone?  That is, the pool will be emptied as the tail of the
request has still not been sent to the client.  This is most true in pipelined
requests.

  Is this really the complete solution?  I suspect the three-pool approach
might solve all these problems;

Connection [lifetime of the socket]

  Response [everything but the handler lives here, 
                 until the entire Response is flushed]

    Request [this pool lives until the response is generated, then dumped.]

This way, the logging phase has everything constructed in the Response
pool, and it can outlive the handler so that real information can be logged.

Bill


Mime
View raw message