httpd-dev mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From Justin Erenkrantz <jerenkra...@apache.org>
Subject Re: [PATCH] Re: Deny from hostname broken in 2.0 on MacOSX 10.2
Date Thu, 03 Oct 2002 15:46:07 GMT
--On Thursday, October 3, 2002 11:37 AM -0400 Jeff Trawick 
<trawick@attglobal.net> wrote:

> I committed the patch as-is...  somebody with recent autoconf can play
> with the quotes later :)

Actually, we can do better than this.

If you pass NI_NAMEREQD to getnameinfo(), it will return an error code of 8 
(forget the symbolic code).  The bigger problem is that server/core.c:778 
throws away the return code.  (Note that your test program doesn't pass 
that, but apr_getnameinfo does.)

We should be failing the lookups when we get an error back from 
getnameinfo().  Your test program modified to pass NI_NAMEREQD on Darwin:

% ./gni_mapped
look up via IPv4: 0/www.ibm.com
look up via IPv6: 8/not found

I'd rather we fixed that than disable IPv6 across the board on Darwin. 
That way, when it is fixed, we don't have to do anything.  And, whenever we 
get an error from apr_getnameinfo(), we don't ignore it.  -- justin

Mime
View raw message