httpd-dev mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From Joe Orton <jor...@redhat.com>
Subject Re: cvs commit: httpd-2.0/server core.c util_script.c
Date Wed, 09 Oct 2002 11:11:57 GMT
On Wed, Oct 02, 2002 at 03:54:18PM -0700, Joshua Slive wrote:
> 
> On Wed, 2 Oct 2002, Marc Slemko wrote:
> > Lets not encode env variables, as we discussed earlier.
> >
> > Escaping them is bogus and doesn't solve anything since there are all
> > sorts of variables that aren't and shouldn't be encoded.
> 
> +1 to what Marc says.  The encoding serves no purpose.  Preventing the
> sample cgi scripts from being included in a "make install" would be a
> great idea.

If this change does get reverted so that SERVER_NAME is not encoded
internally again, the error includes need updating so that is is encoded
there instead:

--- error/include/bottom.html~	2002-07-11 20:07:03.000000000 +0100
+++ error/include/bottom.html	2002-10-09 12:04:59.000000000 +0100
@@ -6,7 +6,7 @@
 <dl>
 <dd>
 <address>
-  <a href="/"><!--#echo encoding="none" var="SERVER_NAME" --></a>
+  <a href="/"><!--#echo encoding="url" var="SERVER_NAME" --></a>
   <br />
   <!--#config timefmt="%c" -->
   <small><!--#echo encoding="none" var="DATE_LOCAL" --></small>

Mime
View raw message