Return-Path: Delivered-To: apmail-httpd-dev-archive@httpd.apache.org Received: (qmail 4940 invoked by uid 500); 13 Sep 2002 07:58:28 -0000 Mailing-List: contact dev-help@httpd.apache.org; run by ezmlm Precedence: bulk Reply-To: dev@httpd.apache.org list-help: list-unsubscribe: list-post: Delivered-To: mailing list dev@httpd.apache.org Received: (qmail 4925 invoked from network); 13 Sep 2002 07:58:27 -0000 Date: Fri, 13 Sep 2002 09:59:36 +0200 From: Kris Verbeeck Subject: [PATCH] [UPDATED] Re: Cached response: 304 send as 200 Sender: krisv@be.ubizen.com To: dev@httpd.apache.org Message-id: <3D819AE8.D4436093@ubizen.com> Organization: Ubizen X-Mailer: Mozilla 4.72 [en] (X11; I; Linux 2.2.17 i686) X-Accept-Language: en References: <3D7DBF8C.6638BF6@ubizen.com> <3D7F55CF.BCFF8565@ubizen.com> <1031901639.12862.28.camel@localhost> X-Sanitizer: Out MIME-Version: 1.0 Content-Type: multipart/mixed; boundary="MIMEStream=_0+181994_6903072433998_0910138241" X-Spam-Rating: daedalus.apache.org 1.6.2 0/1000/N This is a multi-part message in MIME format. --MIMEStream=_0+181994_6903072433998_0910138241 Content-type: text/plain; charset=us-ascii Content-transfer-encoding: 7BIT Brian Pane wrote: > If the read of this field is removed, won't we also need to remove > the code that writes it? Correct, my mistake... new patch has been attached that also removes the writing of the status line. -- ir. Kris Verbeeck Development Engineer Ubizen - Ubicenter - Philipssite 5 - 3001 Leuven - Belgium T: +32 16 28 70 64 F: +32 16 28 70 77 Ubizen - We Secure e-business - www.ubizen.com --MIMEStream=_0+181994_6903072433998_0910138241 Content-type: text/plain; charset=us-ascii; name=mod_disk_cache.c.diff Content-transfer-encoding: 7BIT Content-disposition: inline; filename=mod_disk_cache.c.diff --- mod_disk_cache.c Fri Sep 13 09:44:09 2002 +++ mod_disk_cache.c-PATCHED Fri Sep 13 09:52:44 2002 @@ -484,17 +484,6 @@ r->status = atoi(urlbuff); /* Save status line into request rec */ - rv = apr_file_gets(&urlbuff[0], urllen, dobj->hfd); /* Read status line */ - if (rv != APR_SUCCESS) { - /* XXX log message */ - return rv; - } - - if ((temp = strchr(&urlbuff[0], '\n')) != NULL) /* trim off new line character */ - *temp = '\0'; /* overlay it with the null terminator */ - - r->status_line = apr_pstrdup(r->pool, urlbuff); /* Save status line into request rec */ - h->req_hdrs = apr_table_make(r->pool, 20); /* @@ -592,17 +581,6 @@ } sprintf(statusbuf,"%d", r->status); buf = apr_pstrcat(r->pool, statusbuf, CRLF, NULL); - amt = strlen(buf); - apr_file_write(hfd, buf, &amt); - - /* This case only occurs when the content is generated locally */ - if (!r->status_line) { - r->status_line = ap_get_status_line(r->status); - } - buf = apr_pstrcat(r->pool, r->status_line, "\n", NULL); - amt = strlen(buf); - apr_file_write(hfd, buf, &amt); - buf = apr_pstrcat(r->pool, CRLF, NULL); amt = strlen(buf); apr_file_write(hfd, buf, &amt); --MIMEStream=_0+181994_6903072433998_0910138241--