Mailing-List: contact dev-help@httpd.apache.org; run by ezmlm
Precedence: bulk
Reply-To: dev@httpd.apache.org
Sender: trawick@cs390-1.raleigh.ibm.com
Message-ID: <3D7DFC1F.D79757@attglobal.net>
Date: Tue, 10 Sep 2002 10:05:19 -0400
From: Jeff Trawick <trawick@attglobal.net>
MIME-Version: 1.0
To: dev@httpd.apache.org
Subject: Re: [PATCH] 1.3 NET_SIZE_T is socklen_t on OpenBSD
References: <20020906191752.GM19473@skywalker.bsws.de>
 <m3fzwixflz.fsf@rdu74-177-063.nc.rr.com>
 <20020910115634.GL25748@skywalker.bsws.de>
Content-Type: text/plain; charset=us-ascii
Content-Transfer-Encoding: 7bit

Henning Brauer wrote:
> 
> On Tue, Sep 10, 2002 at 07:12:56AM -0400, Jeff Trawick wrote:
> > Henning Brauer <hb-apache-dev@bsws.de> writes:
> > > +#define NET_SIZE_T socklen_t
> > Does this hold for every level of OpenBSD, or is a version check
> > necessary?
> 
> all versions >= 2.6 have socklen_t.
> 
> Given that We don't support anything below 3.0 any more... ;-)

Your point is well taken, but I don't think it is relevant to Apache
unless it is very 
clear that nobody uses the old releases any more.  If somebody wants to
upgrade their
Apache to pick up an Apache security fix or any other change, we want it
to work, 
regardless of the OS vendor's stance on the OS level they are using.

(My employer is an OS vendor, and when I have to round up an OS guru for
some help
with something and they happen to suggest that we remove some cruft for
supporting an 
out-of-service level of the OS, I give 'em hell :) )

> You could add a #if (OpenBSD >= 199912) if you really want.

Would you be so kind as to test such a patch and resubmit?

Thanks,

Jeff

-- 
Jeff Trawick