httpd-dev mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From Jim Jagielski <...@jaguNET.com>
Subject ap_vformatter (Apache 1.3) patch reversal
Date Fri, 06 Sep 2002 20:02:58 GMT
I think that the below needs to be taken out of ap_vformatter in 1.3.26...
IIRC, it was a back-port of a 2.0 specific bug, regarding apr_psprintf().
This also gets rids of the bogusness of: "It's not possible to
distinguish between an output which was truncated, and an output
which exactly filled the buffer" which this patch caused.

Comments?

Index: src/ap/ap_snprintf.c
===================================================================
RCS file: /home/cvs/apache-1.3/src/ap/ap_snprintf.c,v
retrieving revision 1.51
diff -u -r1.51 ap_snprintf.c
--- src/ap/ap_snprintf.c	14 Mar 2002 12:08:06 -0000	1.51
+++ src/ap/ap_snprintf.c	6 Sep 2002 19:55:29 -0000
@@ -1158,10 +1158,6 @@
 	fmt++;
     }
     vbuff->curpos = sp;
-    if (sp >= bep) {
-	if (flush_func(vbuff))
-	    return -1;
-    }
     return cc;
 }
 

-- 
===========================================================================
   Jim Jagielski   [|]   jim@jaguNET.com   [|]   http://www.jaguNET.com/
      "A society that will trade a little liberty for a little order
             will lose both and deserve neither" - T.Jefferson

Mime
View raw message