httpd-dev mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From r..@apache.org
Subject Re: [PATCH]: Update request in connection based filters
Date Wed, 18 Sep 2002 23:07:53 GMT
On 19 Sep 2002, Bojan Smojver wrote:

> On Thu, 2002-09-19 at 07:59, rbb@apache.org wrote:
> 
> > Great, now one more change.  :-)
> > 
> > Don't add the fields to the structure.  The conn_Rec has a vector for
> > modules to add data to.  Create a log_config structure, and add the fields
> > there.  This allows the core structures to remain as they are, and it
> > still allows for logging the information.  Since the data is collected and
> > used by the same module, there is no reason to put the information in the
> > core structure.
> 
> OK, this is the ap_conf_vector_t *conn_config, right?
> 
> Cool, one less change to make for me. One less MMN bump as well. One
> less module in Apache too. Not bad :-)
> 
> One more thing to consider - the requests are going to be logged in the
> same order they appear on the connection, right? Otherwise, we'll be
> logging the wrong number of I/O bytes per request...

yep, requests are always logged in order.

Ryan

_______________________________________________________________________________
Ryan Bloom                        	rbb@apache.org
550 Jean St
Oakland CA 94610
-------------------------------------------------------------------------------


Mime
View raw message