httpd-dev mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From "Bill Stoddard" <b...@wstoddard.com>
Subject RE: [PATCH] core_output_filter
Date Sat, 21 Sep 2002 15:42:22 GMT
This will definitely break when we try to do non-blocking sends which will
return APR_EAGAIN
Bill

> I have a quick question about some of the logic in the core_output_filter.
>
> When the core_output_filter sends data to the network (via writev_it_all,
> emulate_sendfile, or sendfile_it_all), we check the apr_status_t and log
> an error when rv != APR_SUCCESS.  However, apache only sets c->aborted if
> the status code was ECONNABORTED, ECONNRESET, or EPIPE.
>
> Is there a reason we only set c->aborted for these specific
> return values?
> I think it may make more sense to always set c->aborted if we
> encounter an
> error.  This flag is the only way modules will know if something in the
> filter chain went wrong.
>
> A patch is attached to always set c->aborted on network send errors.
> (although I have only run into this problem with APR_TIMEUP errors, so
>  we could also just add a APR_STATUS_IS_TIMEUP(rv) check)
>
> -Ryan
>
> Index: core.c
> ===================================================================
> RCS file: /home/cvspublic/httpd-2.0/server/core.c,v
> retrieving revision 1.205
> diff -u -r1.205 core.c
> --- core.c      16 Sep 2002 13:11:55 -0000      1.205
> +++ core.c      20 Sep 2002 20:46:52 -0000
> @@ -3910,11 +3910,7 @@
>              if (more)
>                  apr_brigade_destroy(more);
>
> -            if (APR_STATUS_IS_ECONNABORTED(rv)
> -                || APR_STATUS_IS_ECONNRESET(rv)
> -                || APR_STATUS_IS_EPIPE(rv)) {
> -                c->aborted = 1;
> -            }
> +            c->aborted = 1;
>
>              /* The client has aborted, but the request was successful. We
>               * will report success, and leave it to the access and error
>


Mime
View raw message