httpd-dev mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From "Paul J. Reder" <rede...@remulak.net>
Subject Re: [PATCH] caching and query strings
Date Thu, 12 Sep 2002 15:04:27 GMT
But I'm also factoring the hostname into key creation, which
also might be NULL. So even if the args issue could be ignored, the
hostname can't (or at least the possibility of 1 out of 2 NULL
can't be ignored).

Pier Fumagalli wrote:

> "Paul J. Reder" <rederpj@remulak.net> wrote:
> 
> 
>>Yes, I believe it should check r->args. I don't think you are stupid,
>>severely or otherwise... ;)
>>
> 
> That's what _you_ think... Others (like me) tend to disagree! :)
> 
> After thinking about it, it wouldn't really matter, because apr_pstrcat will
> already stop at the first NULL argument passed...
> 
> The only "problem" I see in that approach would be that two requests:
>     http://www.myserver.com/blah?
> and
>     http://www.myserver.com/blah
> would end up with the same key "blah?\0" if you don't check for that
> beforehands (but I don't know exactly how the http stack would parse the
> first request)... I believe this is ignorable...
> 
>     Pier
> 
> 
> 


-- 
Paul J. Reder
-----------------------------------------------------------
"The strength of the Constitution lies entirely in the determination of each
citizen to defend it.  Only if every single citizen feels duty bound to do
his share in this defense are the constitutional rights secure."
-- Albert Einstein



Mime
View raw message