httpd-dev mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From Brian Pane <bri...@apache.org>
Subject Re: cvs commit: httpd-2.0/modules/http http_protocol.c
Date Thu, 05 Sep 2002 06:30:16 GMT
Cliff Woolley wrote:

>On 5 Sep 2002 brianp@apache.org wrote:
>
>  
>
>>       bb = apr_brigade_create(r->pool, r->connection->bucket_alloc);
>>  +    if (bb == NULL) {
>>  +        r->connection->keepalive = AP_CONN_CLOSE;
>>  +        return -1;
>>  +    }
>>    
>>
>
>apr_brigade_create() will never return NULL.  This bit is unnecessary.
>  
>

That's not guaranteed.  The API, as currently documented, only
guarantees that it will return an apr_bucket_brigade*, not that
it will be non-null.

Brian



Mime
View raw message