httpd-dev mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From Henning Brauer <hb-apache-...@bsws.de>
Subject Re: [PATCH] 1.3 NET_SIZE_T is socklen_t on OpenBSD
Date Tue, 10 Sep 2002 15:11:28 GMT
On Tue, Sep 10, 2002 at 10:05:19AM -0400, Jeff Trawick wrote:
> Henning Brauer wrote:
> > On Tue, Sep 10, 2002 at 07:12:56AM -0400, Jeff Trawick wrote:
> > > Henning Brauer <hb-apache-dev@bsws.de> writes:
> > > > +#define NET_SIZE_T socklen_t
> > > Does this hold for every level of OpenBSD, or is a version check
> > > necessary?
> > all versions >= 2.6 have socklen_t.
> > Given that We don't support anything below 3.0 any more... ;-)
> Your point is well taken, but I don't think it is relevant to Apache

I saw this coming, thus the smiley. While I don't see the point of still
supporting 2.0 .. 2.5 from my (OS-Developer) perspective, I would most
probably have acted the same way if I were in your position ;-)

> > You could add a #if (OpenBSD >= 199912) if you really want. 
> Would you be so kind as to test such a patch and resubmit?

Well, as you might imagine I work on -current ;-)
I have a few -stable machines of various releases around, but none of that
vintage.

anyway, this works on -current and should do well on older releases as well.
patch is hand-crufted, might not apply cleanly.

--- ap_config.h.orig	Tue Sep 10 17:05:11 2002
+++ ap_config.h	Tue Sep 10 17:06:41 2002
@@ -692,6 +692,10 @@
 #if defined __OpenBSD__
 #define HAVE_SYSVSEM_SERIALIZED_ACCEPT
 #define USE_SYSVSEM_SERIALIZED_ACCEPT
+#include <sys/param.h>
+#if (OpenBSD >= 199912)
+#define NET_SIZE_T socklen_t
+#endif
 #endif
 #define HAVE_FLOCK_SERIALIZED_ACCEPT
 #define SINGLE_LISTEN_UNSERIALIZED_ACCEPT

-- 
Henning Brauer, BS Web Services, http://bsws.de
hb@bsws.de - henning@openbsd.org
Unix is very simple, but it takes a genius to understand the simplicity.
(Dennis Ritchie)

Mime
View raw message