httpd-dev mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From Greg Stein <gst...@lyra.org>
Subject Re: [PATCH] mod_mime and virtual requests
Date Thu, 05 Sep 2002 18:44:13 GMT
On Thu, Sep 05, 2002 at 11:14:42AM -0400, Ryan Bloom wrote:
> 
> > > Hmm. We might not even need the fixup. Now that *every* handler is executed
> > > nowadays, we can probably just remove the concept of "dav-handler" and move
> > > those checks in type_checker/fixups into dav_handler() itself.
> > 
> > Hmm.  Perhaps.  I'll take a look at it.  -- justin
> 
> Small problem with that.  Not all handlers are run, only the first handler
> to do something is run.  Also, we shouldn't be moving stuff into handlers,
> we should be moving stuff out of them.  The idea of handlers is to
> actually generate the data.  If mod_dav is doing checks, those should be
> done before the handler, so that the dav_handler can return ASAP.

Have you even looked at the frickin' code?

I think it is much better to move the stuff into the handler rather than to
go monkeying with the handler string. We avoid a fixups hook and change a
strcmp() into about three if () statements.

Cheers,
-g

-- 
Greg Stein, http://www.lyra.org/

Mime
View raw message