httpd-dev mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From Brian Pane <>
Subject Re: Counting bytes_sent in core output_filter Re: [PATCH: Apache 2.0] mod_log_config: input/output bytes
Date Wed, 21 Aug 2002 08:13:19 GMT
Justin Erenkrantz wrote:

>On Wed, Aug 21, 2002 at 12:27:29AM -0700, Brian Pane wrote:
>>The remaining problem is: how can we identify the request_rec from
>>within core_output_filter()?  Within that filter, f->r is NULL.  I
>>have some ideas for solving this by putting some metadata in the
>>brigade to associate each EOS with the corresponding request.
>>But is there a better solution that already exists for getting
>>the request_rec?
>Actually, I thought it was already fixed, but you're right the
>connection filters don't yet have access to f->r.
>My thought would be when we create the request, we go through the
>filter stack and 'fixup' all filters in the output_filters chain
>to point at the right request_rec.  Seems easy enough, but I'm not
>100% sure that is clean enough.  -- justin

But filters can be added after the request is created (e.g.,
adding the mod_include filter based on file extension)

I think it would be sufficient to "fixup" just the
core_output_filter, though.


View raw message