httpd-dev mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From Graham Leggett <minf...@sharp.fm>
Subject Re: [PATCH] Close connections in mod_auth_ldap
Date Fri, 19 Jul 2002 06:09:46 GMT
Scott Lamb wrote:

> util_ldap_connection_close() is a misnomer, I think. It just releases a 
> lock. ("I'm done with this LDAP connection," rather than "unbind this 
> LDAP connection.") Since mod_auth_ldap_auth_checker only deals with one 
> of these at a time, a (sub)pool is inappropriate, correct?

I would imagine you would just register the cleanup in the request pool 
r->pool. I assume that *_auth_checker only gets run once per request, so 
the request pool would make the most sense.

> util_ldap_connection_destroy, which does the unbind in ldap-cache, is a 
> pool cleanup already.

Which pool?

> <suit frameproof="true"> As far as cleaner ways to unlock in every way 
> out of the function, there's always C++ destructors. ;) </suit>

C++ is quite a big hammer to be using to solve the a problem as small as 
this ;)

Regards,
Graham
-- 
-----------------------------------------
minfrin@sharp.fm 
	"There's a moon
					over Bourbon Street
						tonight..."


Mime
View raw message