Return-Path: Delivered-To: apmail-httpd-dev-archive@httpd.apache.org Received: (qmail 67571 invoked by uid 500); 18 Jun 2002 05:37:39 -0000 Mailing-List: contact dev-help@httpd.apache.org; run by ezmlm Precedence: bulk Reply-To: dev@httpd.apache.org list-help: list-unsubscribe: list-post: Delivered-To: mailing list dev@httpd.apache.org Received: (qmail 67546 invoked from network); 18 Jun 2002 05:37:39 -0000 Subject: Re: cvs commit: apache-1.3/src/ap ap_strtol.c Makefile.tmpl To: dev@httpd.apache.org Cc: jerenkrantz@apache.org (Justin Erenkrantz), jim@jaguNET.com X-Mailer: Lotus Notes Release 5.0.7 March 21, 2001 Message-ID: From: "David McCreedy" Date: Mon, 17 Jun 2002 23:35:46 -0600 X-MIMETrack: Serialize by Router on d27ml602/27/M/IBM(Release 5.0.10 |March 22, 2002) at 06/18/2002 12:37:47 AM MIME-Version: 1.0 Content-type: text/plain; charset=us-ascii X-Spam-Rating: daedalus.apache.org 1.6.2 0/1000/N I agree with this approach. I've confirmed that TPF's strtol function returns an errno of ERANGE. I don't know if OS390's and BS2000's compilers do as well. Jim has updated ap_strtol.c with an explicit warning: "... this will break on EBCDIC machines if base is >19." And since Apache itself only does base 10 and base 16 I'm not going to do a last minute patch for TPF/EBCDIC. It's not worth the risk of complicating or breaking the T+R of 1.3.25. -David Jim Jagielski To: jerenkrantz@apache.org (Justin Erenkrantz) cc: dev@httpd.apache.org, jim@jaguNET.com 06/17/2002 09:14 Subject: Re: cvs commit: apache-1.3/src/ap ap_strtol.c Makefile.tmpl PM Please respond to dev +1 Justin Erenkrantz wrote: > > On Mon, Jun 17, 2002 at 11:06:30PM -0400, Jim Jagielski wrote: > > With 2.0, we are lucky because we require not only an ANSI compiler > > but also the full ANSI function suite. That's never been the case > > on 1.3. So, at least with 1.3, we can't assume that strtol() works > > as we require, since we don't require strict ANSI functionality. > > We could have done a NEED_STRTOL, but that would require more > > knowledge than we have right now, I'm afraid. > > I guess my point was that we could use the system strtol() for > EBCDIC machines on 1.3 to handle this special case. Since those > machines are typically confined to one particular compiler and > library, we can easily verify that those strtol() implementations > are correct. > > #ifdef CHARSET_EBCDIC > #define ap_strtol strtol > #else > ...... > #endif > > Just a thought. -- justin > -- =========================================================================== Jim Jagielski [|] jim@jaguNET.com [|] http://www.jaguNET.com/ "A society that will trade a little liberty for a little order will lose both and deserve neither" - T.Jefferson