Return-Path: Delivered-To: apmail-httpd-dev-archive@httpd.apache.org Received: (qmail 82054 invoked by uid 500); 18 Jun 2002 16:40:58 -0000 Mailing-List: contact dev-help@httpd.apache.org; run by ezmlm Precedence: bulk Reply-To: dev@httpd.apache.org list-help: list-unsubscribe: list-post: Delivered-To: mailing list dev@httpd.apache.org Received: (qmail 82033 invoked from network); 18 Jun 2002 16:40:57 -0000 From: "Aryeh Katz" To: dev@httpd.apache.org Date: Tue, 18 Jun 2002 12:41:19 -0400 MIME-Version: 1.0 Subject: Re: Memory leak in experimental module - mod_case_filter_in Message-ID: <3D0F2A6F.25329.15130694@localhost> Priority: normal In-reply-to: <3D0F28FC.22904.150D5E3F@localhost> X-mailer: Pegasus Mail for Windows (v4.01) Content-type: text/plain; charset=US-ASCII Content-transfer-encoding: 7BIT Content-description: Mail message body X-OriginalArrivalTime: 18 Jun 2002 16:43:39.0561 (UTC) FILETIME=[4C724990:01C216E7] X-Spam-Rating: daedalus.apache.org 1.6.2 0/1000/N Please ignore. I didn't look at the heap_create code carefully. Sorry. > I was looking over mod_case_filter_in for some pointers on filter > handling, and I noticed there was a memory leak in CaseFilterInFilter > (line 149). Since apr_bucket_heap_create doesn't specify a free > function, apr_bucket_heap_make will allocate h->base, and copy the > data (buf) there. The buf allocated through malloc (in > CaseFilterInFilter) never gets freed, and will leak the amount of data > read through ap_bucket_read on every request. Since this is just an > experimental module it's no big deal, but it probably pays to clean > this up. Aryeh --- Aryeh Katz VASCO www.vasco.com > --- Aryeh Katz VASCO www.vasco.com