Return-Path: Delivered-To: apmail-httpd-dev-archive@httpd.apache.org Received: (qmail 6089 invoked by uid 500); 13 Jun 2002 19:36:52 -0000 Mailing-List: contact dev-help@httpd.apache.org; run by ezmlm Precedence: bulk Reply-To: dev@httpd.apache.org list-help: list-unsubscribe: list-post: Delivered-To: mailing list dev@httpd.apache.org Received: (qmail 6075 invoked from network); 13 Jun 2002 19:36:51 -0000 Message-ID: <3D08E616.2080809@cnet.com> Date: Thu, 13 Jun 2002 11:36:06 -0700 From: Brian Pane User-Agent: Mozilla/5.0 (Windows; U; Windows NT 5.0; en-US; rv:1.0.0) Gecko/20020530 X-Accept-Language: en-us, en MIME-Version: 1.0 To: dev@httpd.apache.org Subject: Re: cvs commit: httpd-2.0/modules/generators mod_cgi.c References: Content-Type: text/plain; charset=us-ascii; format=flowed Content-Transfer-Encoding: 7bit X-Spam-Rating: daedalus.apache.org 1.6.2 0/1000/N Cliff Woolley wrote: >On Thu, 13 Jun 2002, Aaron Bannert wrote: > > > >>On Thu, Jun 13, 2002 at 09:26:27AM -0700, Brian Pane wrote: >> >> >>>Thanks for the quick fix. Time for a 2.0.38 release? >>> >>> >>+1 >> >> > >We need to check all of our handlers for this, and we need to remove the >comment in the core that continues to say that handlers are broken if they >send down the body for a headers_only request. > > Does mod_cgid need the same change? mod_cgid.c:1237: if (!r->header_only) { /* Passing our socket down the filter chain in a pipe bucket * gives up the responsibility of closing the socket, so * get rid of the cleanup. */ apr_pool_cleanup_kill(r->pool, (void *)sd, close_unix_socket); ap_pass_brigade(r->output_filters, bb); } --Brian