httpd-dev mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From "Brad Nicholes" <BNICHO...@novell.com>
Subject Re: [PATCH] - Add a "detached" parameter toap_cgi_build_command() for CGI...
Date Wed, 05 Jun 2002 22:43:10 GMT
I can make the changes to mod_win32 but I don't have an environment to
compile or test in.  I might be better if I check in the changes and
then let you fix up the Win32 side.

Brad

Brad Nicholes
Senior Software Engineer
Novell, Inc., a leading provider of Net business solutions
http://www.novell.com 

>>> wrowe@rowe-clan.net Wednesday, June 05, 2002 3:05:55 PM >>>
At 02:49 PM 6/5/2002, you wrote:
>    I took the build parameters and put them into a cgi_exec_info_t
>structure that is passed to the build_command function.  This cleans
up
>the parameter list.

+1 to this patch.  Feel free to apply [although you might wait for
another
plus one... I'm afraid not many folks are watching this corner of the
server.]

I was going to spout off about ap_ decorating the type, until I noted
that
this header simply won't be included by the average module.  Chance of
type collision is pretty minor.

I'm happy to fix arch/win32/mod_win32, or if you would like to attack
it
at the same time [I'm guessing you have already investigated or
considered
borrowing bits of that code] that would be terrific.

Since we've already bit the mmn bump hurdle, this is a no-brainer for
inclusion -before- we roll 2.0.37

Bill


Mime
View raw message