httpd-dev mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From Greg Ames <grega...@apache.org>
Subject Re: cvs commit: httpd-2.0/modules/http http_request.c
Date Mon, 24 Jun 2002 14:28:38 GMT
Justin Erenkrantz wrote:
> 
> On Fri, Jun 21, 2002 at 04:02:52PM -0400, Greg Ames wrote:

> > I think this change to
> > ap_discard_request_body would work:
> >
> > --- modules/http/http_protocol.c        19 Jun 2002 18:43:28 -0000      1.440
> > +++ modules/http/http_protocol.c        21 Jun 2002 19:41:00 -0000
> > @@ -1882,7 +1882,7 @@
> >       *
> >       * This function is also a no-op on a subrequest.
> >       */
> > -    if (r->main || ap_status_drops_connection(r->status)) {
> > +    if (r->main || !r->connection->keepalive) {
> >          return OK;
> >      }
> 
> Hmm.  I'm not sure if I like that or not.  What if ap_die isn't
> involved and the status is set to drop the connection?  

Can that happen?  Well, it would be safer to assume it could.

> Perhaps we could just add the closing of the socket as another
> condition? 

Fair enough.  I'll take care of it if nobody has beaten me to it.

Greg

Mime
View raw message